Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need flag to enable CompilerOptions.setAssumeStaticInheritanceRequired(true) #3559

Open
brad4d opened this issue Feb 25, 2020 · 3 comments
Open

need flag to enable CompilerOptions.setAssumeStaticInheritanceRequired(true) #3559

brad4d opened this issue Feb 25, 2020 · 3 comments
Labels
good first issue Relatively easy, but low priority bugs P3

Comments

@brad4d
Copy link
Contributor

brad4d commented Feb 25, 2020

To avoid compilation breaking uses of this and super in static methods of ES6 classes, you have to get CommandLineRunner to do CompilerOptions.setAssumeStaticInheritanceRequired(true) when creating the Compiler object.

Unfortunately, there is no flag for this yet, and we can't make it the default behavior because of increase in output code size it causes for Google projects.

This would be a good community-volunteer thing to do.
@brad4d brad4d added P3 good first issue Relatively easy, but low priority bugs labels Feb 25, 2020
@brad4d brad4d mentioned this issue Feb 25, 2020
Closed
@niloc132 niloc132 mentioned this issue Jul 14, 2020
Closed
@cshung
Copy link
Contributor

cshung commented Oct 3, 2020

@brad4d
I am interested in this one.

@brad4d
Copy link
Contributor Author

brad4d commented Oct 5, 2020

@cshung thanks for your interest. We'll look out for a PR from you.

rorye added a commit to rorye/closure-compiler that referenced this issue Sep 8, 2021
@rorye
Adding command line flag for setAssumeStaticInheritanceRequired, fix …
9653b20 
…for google#3559
@rorye rorye mentioned this issue Sep 8, 2021
Merged
@adiroy05
Copy link

i can also do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Relatively easy, but low priority bugs P3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brad4d @cshung @adiroy05