Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding command line flag for setAssumeStaticInheritanceRequired #3864

Conversation

rorye
Copy link
Contributor

@rorye rorye commented Sep 8, 2021

Fix for #3559

@google-cla
Copy link

google-cla bot commented Sep 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Sep 8, 2021
@rorye
Copy link
Contributor Author

rorye commented Sep 8, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 8, 2021
@brad4d brad4d self-assigned this Sep 15, 2021
@brad4d
Copy link
Contributor

brad4d commented Sep 21, 2021

I've imported this PR and sent it for internal review and testing.

@brad4d brad4d removed their request for review September 21, 2021 18:08
@brad4d
Copy link
Contributor

brad4d commented Sep 29, 2021

FYI, I've had to reverse the name of the flag and the logic around it to be consistent with our flag conventions.
--assume_something=true is expected to always enable more optimizations, not disable optimizations.

I expect to land the modified PR in the next day or two.

@copybara-service copybara-service bot merged commit ac411ec into google:master Sep 30, 2021
@rorye rorye deleted the add-flag-assume-static-inheritance-required branch October 20, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants