-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Native ES6 support (without transpilation) in advanced mode #950
Labels
Comments
Closed
brad4d
pushed a commit
that referenced
this issue
Apr 11, 2017
…copes. This gets us most of the way to being able to switch InlineVariables to use the ES6 scope creator. Related to #949 Related to #950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=152840654
dimvar
pushed a commit
that referenced
this issue
Apr 19, 2017
Currently these are equivalent so this change is a no-op. However, when we switch this pass to use the ES6 scope creator (which I hope to do soon) it will make a difference. Local scopes that aren't function scopes do not have an 'arguments' variable. Part of #950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=153535657
brad4d
pushed a commit
that referenced
this issue
May 5, 2017
Part of #950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=155096028
brad4d
pushed a commit
that referenced
this issue
Jun 6, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making #949 and #950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158156537
brad4d
pushed a commit
that referenced
this issue
Jun 8, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making #949 and #950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158329151
MatrixFrog
pushed a commit
that referenced
this issue
Jun 13, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making #949 and #950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158568215
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
…copes. This gets us most of the way to being able to switch InlineVariables to use the ES6 scope creator. Related to google#949 Related to google#950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=152840654
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
Currently these are equivalent so this change is a no-op. However, when we switch this pass to use the ES6 scope creator (which I hope to do soon) it will make a difference. Local scopes that aren't function scopes do not have an 'arguments' variable. Part of google#950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=153535657
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
Part of google#950 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=155096028
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making google#949 and google#950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158156537
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making google#949 and google#950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158329151
Yannic
pushed a commit
to Yannic/com_google_closure_compiler
that referenced
this issue
Jul 6, 2017
When this flag is passed, the compiler will skip any passes that are not compatible with the output language. Importantly, that includes typechecking and most optimizations. Whether a pass understands ES2015 (or ES2016, etc.) is determined by its featureSet method DefaultPassConfig. For now, I've marked several passes as ES2015-compatible or higher, that we know have been updated to comprehend ES2015, or have tests indicating that they do. We'll continue to add featureSet overrides as we make more passes ES2015-compatible. A lot of that work will happen in the next few months. This is a big part of making google#949 and google#950 work. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=158568215
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Allow ES6 as both the input and output language, in advanced mode.
The text was updated successfully, but these errors were encountered: