Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

Compilation error for sha2.js #402

Closed
koto opened this issue Jan 20, 2015 · 2 comments
Closed

Compilation error for sha2.js #402

koto opened this issue Jan 20, 2015 · 2 comments

Comments

@koto
Copy link
Member

koto commented Jan 20, 2015

closure-library/closure/goog/crypt/sha2.js:201: ERROR - Bad type annotation. missing closing >
 *  @param {Array.<Uint32Array[80]>} precomputed_schedule An SHA2-32b schedule

It's gone if I just remove the "[80]".

@Ubehebe
Copy link
Contributor

Ubehebe commented Jan 20, 2015

@koto Thanks for catching this. Here's what happened:

  • Last week, I merged Perf improvements for sha1.js, sha2.js, and sha2_64b.js #391 by @coruus.
  • The PR broke several unit tests (see PR discussion), and also doesn't compile, as you noticed.
  • I rewrote the project's history using git push --force to make it so that the PR had never been merged.
  • But I must not have done this correctly, since @coruus' original commit (e9dcd0b) was from August, and it remained in the project's history.

I have now reverted e9dcd0b in 2a79f2b and the library should build again. Please verify and close this issue if it works.

@koto
Copy link
Member Author

koto commented Jan 20, 2015

It works now, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants