Add type information to goog.global referenced objects #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unknown and blocking disambiguation on properties named "open" or "send".
| @@ -1396,6 +1396,7 @@ goog.loadFileSync_ = function(src) { | |||
| if (goog.global.CLOSURE_LOAD_FILE_SYNC) { | |||
| return goog.global.CLOSURE_LOAD_FILE_SYNC(src); | |||
| } else { | |||
| /** @type {XMLHttpRequest} */ | |||
| var xhr = new goog.global['XMLHttpRequest'](); | |||
There was a problem hiding this comment.
I'm wondering if we can just kill the bracket notation here instead.
There was a problem hiding this comment.
The other option would be to increase the bracket usage:
xhr['open']('get', src, false);
This is also occurring on Line 850 which doesn't use brackets.
|
You would also need to add a "goog.forwardDeclare" for this type, this is there to support projects using minimal externs. |
ChadKillingsworth
changed the title
goog.loadFileSync_.
|
Added the needed |
concavelenz
added a commit
that referenced
this pull request
Aug 11, 2015
Add type information to goog.global referenced objects.
joeltine
added a commit
that referenced
this pull request
Aug 12, 2015
Add type information to goog.global referenced objects. ------------- Created by MOE: http://code.google.com/p/moe-java ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=100492682
joeltine
added a commit
that referenced
this pull request
Aug 14, 2015
*** Reason for rollback *** Breaks test With this rollback, all tests pass. *** Original change description *** Merge pull request #503 from ChadKillingsworth/fix-unknown-type-in-base Add type information to goog.global referenced objects. ------------- Created by MOE: http://code.google.com/p/moe-java *** ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=100526080
joeltine
added a commit
that referenced
this pull request
Aug 14, 2015
*** Reason for rollback *** Roll forward once is in to unbreak tests after this change. (I'm queuing these up since the presubmits are long.) *** Original change description *** Automated g4 rollback of changelist 100492682. *** Reason for rollback *** Breaks tests *** Original change description *** Merge pull request #503 from ChadKillingsworth/fix-unknown-type-in-base Add type information to goog.global referenced obj... *** ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=100537995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xhrobject created via goog.global was an unknown type and thus blocked disambiguation on properties named "open" or "send".Fixes google/closure-compiler#1054