This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
fix cli errors #273
Closed
fix cli errors #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jay0lee
commented
Jul 18, 2016
jay0lee
commented
- fix codegangsta/cli deprecated cli.App.RunAndExitOnError #223 cli errors
- codegangsta/cli is now urfave/cli
-codegangsta/cli is now urfave/cli
| @@ -161,12 +161,12 @@ var commonCommands = []cli.Command{ | |||
| } | |||
|
|
|||
| // getConfig returns a config object | |||
| func getConfig(context *cli.Context) *lib.Config { | |||
| func getConfig(context *cli.Context) (*lib.Config, error) { | |||
| config, _, err := lib.GetConfig(context) | |||
| if err != nil { | |||
| log.Fatalln(err) | |||
There was a problem hiding this comment.
Have you considered returning err in these kinds of cases?
|
There might be a better way to handle errors now using the cli framework. If it doesn't seem like the cli error handling would be very helpful, I am happy accepting this change if you put some comments where we call the cli code explaining this. |
| app.Action = func(context *cli.Context) { | ||
| os.Exit(connector(context)) | ||
| app.Action = func(context *cli.Context) error { | ||
| return_code, _ := connector(context) |
There was a problem hiding this comment.
The whitespace here is inconsistent, please run go fmt.
|
Resolved by #283 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.