Fix for struct needed to get downgraded to handle pointerbitcast #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When guessing the type from the users, do not consider aliasing when type match the first element of the struct. Fix DowngradeSourceToTy to avoid modifying node on which we are iterating. No regression on CTS with swiftshader and nvidia Fix google#1184 Fix google#1185
alan-baker
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When guessing the type from the users, do not consider aliasing when type match the first element of the struct.
Fix DowngradeSourceToTy to avoid modifying node on which we are iterating.
No regression on CTS with swiftshader and nvidia
Fix #1184
Fix #1185