-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fuzz crashes uworker safe #4000
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
approved these changes
May 21, 2024
@@ -609,7 +609,7 @@ def get_proto_corpus(bucket_name, | |||
gcs_url, num_uploads=max_upload_urls) | |||
corpus = uworker_msg_pb2.Corpus( | |||
corpus_urls=corpus_urls, | |||
upload_urls=upload_urls, | |||
upload_urls=upload_urls, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
erroneous change?
e7e91a0
to
22e1108
Compare
785ab77
to
5518d89
Compare
9510770
to
ee3fa5a
Compare
vitorguidi
added a commit
that referenced
this pull request
Jul 2, 2024
This reverts commit 4a17b2f.
vitorguidi
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 4a17b2f.
jonathanmetzman
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 4a17b2f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the most important part of migrating fuzz_task.
This superseeds: #3834 and #3816