Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/revert uworker safe #4088

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

vitorguidi
Copy link
Collaborator

We apparently had a drop in succesful batch runs from #4000 and subsequent PRs, so reverting for good measure

@jonathanmetzman
Copy link
Collaborator

I don't think we should revert this yet.

  1. The brekage is not user-visible yet as it only affects fuzz_task.
  2. I am addressing the errors now and should have fixes for all of them in the next 30 minutes.
  3. The errors don't appear easy to reproduce locally so having them occur in prod is valuable teaching moments.

@jonathanmetzman
Copy link
Collaborator

I also somewhat doubt the batch metric is correctly reading this. Most batch jobs are probably not the result of fuzzing from that day.

@vitorguidi
Copy link
Collaborator Author

I also somewhat doubt the batch metric is correctly reading this. Most batch jobs are probably not the result of fuzzing from that day.

What would be desirable for us to debug this kind of issue in the future? Success rate, given a fuzzing task start time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants