Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose more of the hints addon #30

Merged
merged 2 commits into from
Mar 24, 2015
Merged

expose more of the hints addon #30

merged 2 commits into from
Mar 24, 2015

Conversation

devoncarew
Copy link
Contributor

Fix #28

@devoncarew devoncarew mentioned this pull request Mar 24, 2015
Closed
@devoncarew
Copy link
Contributor Author

I think self is the this pointer for the completion handler instance, with the from, to, and list of available completions. data is the this pointer for the individual completion - the JS this pointer. We already have the Dart version of that, so we ignore the JS one.

Good to know that from is always available; I was making that assumption but hadn't confirmed it.

devoncarew added a commit that referenced this pull request Mar 24, 2015
@devoncarew
Merge pull request #30 from google/devoncarew_hints
49c47b8 
expose more of the hints addon
@devoncarew devoncarew merged commit 49c47b8 into master Mar 24, 2015
@devoncarew
Copy link
Contributor Author

updated param names: 5c9fb97

@kasperpeulen
Copy link
Contributor

@devoncarew cool :)

@devoncarew devoncarew deleted the devoncarew_hints branch April 20, 2015 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

expose completion.hint
2 participants
@devoncarew @kasperpeulen