Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename LICENSE.txt to LICENSE #196

Closed
wants to merge 1 commit into from
Closed

Rename LICENSE.txt to LICENSE #196

wants to merge 1 commit into from

Conversation

CodeMaster7000
Copy link
Contributor

@CodeMaster7000 CodeMaster7000 commented Jan 20, 2023

The file should be named LICENSE per https://github.com/google/new-project.

@CodeMaster7000 CodeMaster7000 closed this by deleting the head repository Jan 20, 2023
@mgeisler
Copy link
Collaborator

Hey @CodeMaster7000,

Thanks, you're right that the file should be named LICENSE — I see that https://github.com/google/new-project uses that name too.

Can you update https://github.com/google/comprehensive-rust/blob/main/src/credits.md too?

@mgeisler mgeisler changed the title Update and rename LICENSE.txt to LICENSE as it a more standard name of a license file Rename LICENSE.txt to LICENSE Jan 24, 2023
Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the credits page to link to the new name.

@@ -1,4 +1,3 @@

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't edit the license file — we could keep it exactly like https://github.com/google/new-project/blob/master/LICENSE.

Copy link
Contributor Author

@CodeMaster7000 CodeMaster7000 Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks for the feedback!

@CodeMaster7000
Copy link
Contributor Author

CodeMaster7000 commented Jan 24, 2023

I have made the changes that you requested @mgeisler. Since the head repository has been deleted, I can no longer go back and make changes to this PR. However, #272 has the requested changes so both PRs should be ready to be merged.

@mgeisler
Copy link
Collaborator

Since the head repository has been deleted, I can no longer go back and make changes to this PR. However, #272 has the requested changes so both PRs should be ready to be merged.

Thanks for fixing the credits page.

I believe this PR still removes the line at the top of LICENSE? Since the repository was deleted, I suggest we close both PRs and you can then open a new single PR which does both changes in one commit (you'll need to clone it down on your own machine for this).

@CodeMaster7000
Copy link
Contributor Author

@mgeisler Refer to #293 for the updated PR that reflects both of those requirements. I have also closed these 2 PRs. Thank you for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants