-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LICENSE.txt to LICENSE #196
Conversation
Hey @CodeMaster7000, Thanks, you're right that the file should be named Can you update https://github.com/google/comprehensive-rust/blob/main/src/credits.md too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the credits page to link to the new name.
@@ -1,4 +1,3 @@ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't edit the license file — we could keep it exactly like https://github.com/google/new-project/blob/master/LICENSE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Thanks for the feedback!
Thanks for fixing the credits page. I believe this PR still removes the line at the top of |
The file should be named
LICENSE
per https://github.com/google/new-project.