Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ru: Translation for the welcome page and chapters 1,2 #724

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

baltuky
Copy link
Collaborator

@baltuky baltuky commented May 29, 2023

Russian translation (#326) of the following chapters
Welcome to Comprehensive Rust 🦀
1. Running the Course
2. Using Cargo

@baltuky baltuky force-pushed the ru_welcome_ch_1_2 branch 2 times, most recently from cab31c5 to 0eadc33 Compare May 29, 2023 18:23
@baltuky baltuky changed the title ru: Translate the welcome page and chapters 1,2 ru: Translation for the welcome page and chapters 1,2 May 29, 2023
@baltuky
Copy link
Collaborator Author

baltuky commented Jun 1, 2023

@mgeisler It would be nice to find someone who speaks Russian and can review these changes 🔍

po/ru.po Outdated Show resolved Hide resolved
@mgeisler
Copy link
Collaborator

mgeisler commented Jun 2, 2023

@mgeisler It would be nice to find someone who speaks Russian and can review these changes mag

Yes, I asked around and it seems like @ramosian-glider has volunteered to help out! 🎉

po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
@Phil9l
Copy link

Phil9l commented Jun 2, 2023

Also a nit about ё/е:

https://github.com/rust-lang-ru/book

Зачем ещё один репозиторий?

https://github.com/rust-lang-ru/dictionary

capacity ёмкость

But this PR uses "е" for both.

@baltuky baltuky force-pushed the ru_welcome_ch_1_2 branch 4 times, most recently from cdf0830 to 6545d8b Compare June 2, 2023 16:53
@baltuky
Copy link
Collaborator Author

baltuky commented Jun 2, 2023

Also a nit about ё/е:

https://github.com/rust-lang-ru/book

Зачем ещё один репозиторий?

https://github.com/rust-lang-ru/dictionary

capacity ёмкость

But this PR uses "е" for both.

If I'm not mistaken it's allowed to use е instead of ё. Anyway, I've replaced е to ё whenever it made sense. Hope I didn't miss anything 🤞

po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
@baltuky baltuky force-pushed the ru_welcome_ch_1_2 branch 3 times, most recently from 20b6280 to ffb1897 Compare June 5, 2023 16:11
@baltuky
Copy link
Collaborator Author

baltuky commented Jun 5, 2023

@ramosian-glider Looks like I've accepted/fixed the major part of the suggestions and I propose we merge this PR. All further improvements could be accepted in subsequent PRs. WDYT ?

po/ru.po Outdated Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
@baltuky baltuky force-pushed the ru_welcome_ch_1_2 branch 2 times, most recently from 3d9278d to 997b70c Compare June 6, 2023 16:30
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Outdated Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
@baltuky baltuky force-pushed the ru_welcome_ch_1_2 branch 2 times, most recently from 34f49e5 to 3529fe8 Compare June 8, 2023 21:58
po/ru.po Show resolved Hide resolved
po/ru.po Show resolved Hide resolved
@zvonden zvonden enabled auto-merge (squash) June 13, 2023 13:45
@zvonden zvonden requested review from zvonden and removed request for ramosian-glider June 13, 2023 13:49
@zvonden zvonden merged commit 078a998 into google:main Jun 13, 2023
@baltuky baltuky deleted the ru_welcome_ch_1_2 branch July 26, 2023 20:41
@1dimir 1dimir mentioned this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants