Fixing various errors/warnings for windows. #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kruton this gets us a lot closer to building on windows. Just a few misc items remain. |
kruton
reviewed
Jan 9, 2017
| @@ -487,7 +492,7 @@ static bool throwExceptionIfNecessary(JNIEnv* env, const char* location __attri | |||
| } | |||
|
|
|||
| ERR_clear_error(); | |||
| return result; | |||
| return result != 0; | |||
There was a problem hiding this comment.
Might make sense to change this too a bool instead.
| @@ -9173,7 +9180,7 @@ static bool get_ocsp_single_responses(CBS *basic_response, CBS *single_responses | |||
| } | |||
|
|
|||
| // Extract the list of SingleResponse. | |||
| return CBS_get_asn1(&response_data, single_responses, CBS_ASN1_SEQUENCE); | |||
| return CBS_get_asn1(&response_data, single_responses, CBS_ASN1_SEQUENCE) != 0; | |||
There was a problem hiding this comment.
I like it more when we use "== 1" but that might be a holdout when OpenSSL returned a tri-state with 0 meaning not successful and -1 meaning error.
| @@ -20,34 +20,39 @@ | |||
|
|
|||
| #define TO_STRING1(x) #x | |||
| #define TO_STRING(x) TO_STRING1(x) | |||
| #ifndef JNI_JARJAR_PREFIX | |||
| #ifdef JNI_JARJAR_PREFIX | |||
| #define CONSCRYPT_SYMBOL_PREFIX = TO_STRING(JNI_JARJAR_PREFIX) | |||
There was a problem hiding this comment.
Hmm, what does the = do here?
|
@kruton PTAL |
kruton
approved these changes
Jan 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.