Adding new ciphers for TLS 1.3 draft #24
Conversation
|
@kruton the formatting of the list used tabs .... I've converted it to spaces. Unfortunately, the github diff doesn't seem to be very clever. |
|
We intentionally disconnected the TLS 1.3 ciphers from cipher suite language. This should not be necessary. Are you building against an older BoringSSL? That should not be supported. |
|
(You also should not be adding TLS 1.3 support to Conscrypt right now. It is still a draft and Conscrypt will need some work around session management to do it right. We'll get to it in due time but are focused on other consumers right now.) |
|
@davidben No, I'm building against master head. I've checked and they're still in there ... and conscrypt is picking them up. |
|
The ciphers are in there, but they are disconnected from the cipher suite language. Conscrypt shouldn't be picking them up. Are you sure you are building against master and not chromium-stable? |
|
@davidben It does seem to be related to my environment somehow. I had separate directories for both branches, but my environment variable was pointed to master so it should have picked it up. Anyway, I've deleted the chromium-stable code and it seems to be working. Thanks for the help |
Fixes #23