Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] refactor the code so it's easier to understand the execution flow #161

Merged
merged 2 commits into from
Jun 23, 2021
Merged

[NFC] refactor the code so it's easier to understand the execution flow #161

merged 2 commits into from
Jun 23, 2021

Conversation

gchatelet
Copy link
Collaborator

This is a non functional change, it's a small refactoring with more comments so it's easier to follow along.

@gchatelet gchatelet requested a review from Mizux June 22, 2021 18:48
Mizux
Mizux approved these changes Jun 23, 2021
View reviewed changes
src/cpuinfo_x86.c Outdated Show resolved Hide resolved
Mizux
Mizux approved these changes Jun 23, 2021
View reviewed changes
Copy link
Collaborator

@Mizux Mizux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gchatelet gchatelet merged commit 646b80f into master Jun 23, 2021
@gchatelet gchatelet deleted the restructure_code branch October 26, 2021 13:12
@gchatelet gchatelet added this to the v0.7.0 milestone Mar 8, 2022
@gchatelet gchatelet added the misc non user facing: internal, cleanup, ci, release process label Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mizux Mizux Mizux approved these changes

Assignees
No one assigned
Labels
misc non user facing: internal, cleanup, ci, release process
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gchatelet @Mizux