Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate DaggerFoo rather than Dagger_Foo for generated implementations #143

Closed
cgruber opened this issue Apr 1, 2015 · 1 comment
Closed

Comments

@cgruber
Copy link

cgruber commented Apr 1, 2015

We are normalizing on a practice of using _ only in names of implementation details (e.g. AutoFactory_Blah). But since in Dagger we expect client code to directly invoke component implementations to get their builders, and to directly act on the builders, they shouldn't be dealing with Foo_Bar_Blah classes.

So for... @Component interface Foo { ... } we will generate DaggerFoo.

@cgruber cgruber added this to the Dagger 2.0 Release milestone Apr 6, 2015
@cgruber
Copy link
Author

cgruber commented Apr 7, 2015

Implemented in #145

@cgruber cgruber closed this as completed Apr 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant