Merge from google (via MOE) #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "", | ||
| "@Module", | ||
| "final class ModuleWithParameters {", | ||
| " ModuleWithParameters(Object whatever) {}", |
|
The fixes for this build are all working their way through internal review. If we can get them all done and synced out, we should still be able to release today. |
…improve the error message to tell you the dependency path that led to the invalid type. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89884806
* Add validation for subcomponent factory methods. Malformed methods will get flagged with (hopefully) helpful error messages. * Add some friendly error messages for component methods as well. * Allow subcomponent factory methods to accept modules, particularly modules without default constructors. Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89910213
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89915663
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89982588
(Once Guice syncs with google's internal both systems will share this behavior) ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=89998087
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90009415
…rather than Dagger_ ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90217115
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90228800
…rastructure that detects it to ensure consistent behavior. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90283952
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90290342
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90429548
…e open-source project. ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90433194
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90455224
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90516262
…ce to rc2. Note: This altered the xml formatting, which will be fixed in a later commit ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90524096
------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=90525706
cgruber
force-pushed
the
moe_writing_branch_from_9f986abd0f985e717dde1476aeaf058df50064ff
branch
from
bad5d89
to
f03415a
Compare
This was referenced Apr 7, 2015
Closed
Closed
|
LGTM |
This was referenced Apr 7, 2015
Closed
|
|
||
| static final String MEMBERS_INJECTION_WITH_UNBOUNDED_TYPE = | ||
| "Type parameters must be bounded for members injection."; | ||
| "Type parameters must be bounded for members injection. (%s required by %s, via:\n%s"; |
There was a problem hiding this comment.
Addressed in a forthcoming commit.
cgruber
added a commit
that referenced
this pull request
Apr 7, 2015
…f985e717dde1476aeaf058df50064ff Merge from google (via MOE)
cgruber
deleted the
moe_writing_branch_from_9f986abd0f985e717dde1476aeaf058df50064ff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to validations,
@Subcomponents, easier map binding key use, and other various fixes.