Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracker for frontend client changes #67

Open
seehamrun opened this issue Jan 18, 2018 · 0 comments
Open

Tracker for frontend client changes #67

seehamrun opened this issue Jan 18, 2018 · 0 comments
Labels
backlog

Comments

@seehamrun
Copy link
Member

General catch-all tracker for any front end client changes. Any front end changes require a new static content deployment to cloud (build script under /config/gcp/build_and_deploy_static_content.sh) as well as a new binary build and rollout.
This was referenced Jan 18, 2018
Merged
Merged
seehamrun added a commit that referenced this issue Jan 25, 2018
@seehamrun
Use new DataTypes module in angular front end (#80)
95f3763 
* angular front end to talk to api with new DataTransferRequest type.
Angular XHR doesnt follow redirects from POST without an intial
preflight task. To get around this, we dont redirect from configure and
instead return a url in the response to follow. (Similar to the way we
display a page for import setup and redirect to the auth flow).
* rename /configure endpoint to /_/configure
* Rename DataTransfer type to DataTransferResponse
* Rename ConfigureHandler to DataTransferHandler
* Use interface for DataTransferResponse instead of class on angular
frontend. This is so that the response of the POST request isnt bound to
a type but rather to the interface.
* formatting fixes, new lines, license headers

This requires a new build and static content deployment (tracked in #67)
@seehamrun seehamrun mentioned this issue Jan 25, 2018
Merged
@rtannenbaum rtannenbaum mentioned this issue Jan 26, 2018
Closed
This was referenced Jan 26, 2018
Merged
Merged
seehamrun added a commit that referenced this issue Jan 26, 2018
@seehamrun
Update index.html for prod and explicity turn off encryptedFlow (#95)
8f88837 
This updates the prod binary and static content with changes from #80 and #89

Front end changes tracked in: #67
This was referenced Jan 26, 2018
Merged
Merged
Merged
@rtannenbaum rtannenbaum mentioned this issue Feb 13, 2018
Merged
@rtannenbaum rtannenbaum mentioned this issue Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seehamrun @holachuy