Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include timestamp in DriveImporter root folder #1309

Merged

Conversation

alexeyqu-fb
Copy link
Collaborator

@alexeyqu-fb alexeyqu-fb commented Dec 1, 2023

Change the root folder name from MigratedContent to transfer-%Y-%m-%d-%H-%M-%S.

Before After
MigratedContent transfer-2023-11-29-23-01-28

Summary: 

Test Plan: 

Reviewers: 

Subscribers: 

Tasks: 

Tags: 


Differential Revision: https://phabricator.intern.facebook.com/D51749528
wmorland
wmorland previously approved these changes Dec 5, 2023
Copy link
Collaborator

@wmorland wmorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although it might be nice to have a datetime which is more meaningful to the user, see my comment

@alexeyqu-fb alexeyqu-fb merged commit 2cffbf2 into google:master Dec 8, 2023
5 checks passed
@alexeyqu-fb alexeyqu-fb deleted the fix/include-timestamp-drive-root-folder branch December 8, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants