Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add userAlias field to PortabilityJob class #1334

Conversation

alexeyqu-fb
Copy link
Collaborator

@alexeyqu-fb alexeyqu-fb commented Feb 13, 2024

Needed to customize folder names on the destination sides.

./gradlew build test

Copy link
Collaborator

@wmorland wmorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When possible we should add an example of how this is used either in comment or code.

@alexeyqu-fb
Copy link
Collaborator Author

This will be done in follow-up PRs, yes.

@alexeyqu-fb alexeyqu-fb merged commit b587143 into google:master Feb 14, 2024
5 checks passed
@alexeyqu-fb alexeyqu-fb deleted the feature/add-user-alias-field-to-PortabilityJob branch February 14, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants