Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new ahu type #1023

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

added new ahu type #1023

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a8d1633
added new ahu type
kevin-hereworks May 10, 2023
4a1f20a
added to ahu entity type
kevin-hereworks May 10, 2023
8203894
fixed run mode
kevin-hereworks May 10, 2023
247d4f2
fixed error on type
kevin-hereworks May 10, 2023
2888c6f
addede telemetry fields
kevin-hereworks May 10, 2023
4af6b6d
added states
kevin-hereworks May 10, 2023
c6863fd
typo
kevin-hereworks May 10, 2023
21a2abf
typo
kevin-hereworks May 10, 2023
19406f2
Merge branch 'master' into new-ahu-entity
cstirdivant Jul 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5648,6 +5648,11 @@ CPVSC2X:
guid: "1be3e1ba-1a25-4b9a-9784-e4bbd9313db5"
description: "Circulation pump variable speed control with 2 circulation pumps."
is_abstract: true
opt_uses:
- failed_circulation_pump_alarm_1
- failed_circulation_pump_alarm_2
- circulation_pump_speed_percentage_setpoint
- low_supply_water_temperature_alarm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that the temperature point is relevant for the pump's speed control.

uses:
- circulation_pump_run_command_1
- circulation_pump_run_command_2
Expand Down Expand Up @@ -6618,3 +6623,69 @@ VMADC:
- mixed_air_damper_percentage_sensor
implements:
- CONTROL

SEDPM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use case for these on the unit you're looking at? l would not think of these as required points but perhaps they could be added as optional on existing abstract types.

description: "Supply, exhaust pressure monitoring"
is_abstract: true
uses:
- supply_air_differential_pressure_sensor
- exhaust_air_differential_pressure_sensor
implements:
- MONITORING

DXC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each compressor should have its own run status. Flag as missing for your unit if you don't see them rather than creating a new type.

description: "Compressor with 3 stage cooling control, single status"
is_abstract: true
uses:
- cooling_percentage_command
- compressor_run_command_1
- compressor_run_command_2
- compressor_run_command_3
- compressor_run_status
- failed_compressor_alarm
implements:
- CONTROL

SEMC:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in the fields section.

description: "Season mode control"
is_abstract: true
uses:
- supply_air_temperature_setpoint_1
- supply_air_temperature_setpoint_2
- winter_outside_temperature_setpoint
- summer_outside_temperature_setpoint
- supply_air_deadband_temperature_setpoint
- season_mode
implements:
- CONTROL

HWVPM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it has a command then it should have a sensor. See if you can use HWVM and flag your unit as missing the sensor if you don't see it.

description: "Heating water valve percent monitoring"
is_abstract: true
uses:
- heating_water_valve_percentage_command
implements:
- MONITORING

HRCM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sensor is not very useful on it own. Do you have any of the other points in EHHRC?

description: "Heat recovery coil monitoring"
is_abstract: true
uses:
- leaving_heat_recovery_coil_temperature_sensor
implements:
- MONITORING

WDPCA2X:
Copy link
Collaborator

@shambergoldstein shambergoldstein Jun 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide a screenshot of where you are seeing this to digitalbuildings-support@googlegroups.com if possible?

description: "Differential pressure control on run around coil with 2 pumps."
is_abstract: true
opt_uses:
- pressurization_request_count
- high_differential_pressure_alarm_1
- high_differential_pressure_alarm_2
- low_differential_pressure_alarm_1
- low_differential_pressure_alarm_2
uses:
- differential_pressure_sensor
- differential_pressure_setpoint
implements:
- OPERATIONAL
28 changes: 28 additions & 0 deletions ontology/yaml/resources/HVAC/entity_types/AHU.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3982,6 +3982,34 @@ AHU_SFSS_SFMSC_SFVSC_FDPM_CHWSC_RTM_RACO2C_SSPC2X_VOADM2X_SAIDC2X_RAIDC2X_SSPC:
- RAIDC2X
- SSPC

AHU_EFVSC_EDM_SFVSC_SDM_STDSPC_RTM_STC_ETM_OA_MTM_CPVSC2X_SEDPM_DXC_SEMC_SFM_HWVPM_HRCM_WDPCA2X_RMM:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other comments and revisit this.

description: "AHU with dx compressor monitoring, supply temperature, supply and exhaust fan control."
is_canonical: true
implements:
- AHU
- EFVSC
- EDM
- SFVSC
- SDM
- STDSPC
- RTM
- STC
- ETM
- OA
- MTM
- CPVSC2X
- SEDPM
- DXC
- SEMC
- SFM
- HWVPM
- HRCM
- WDPCA2X
- RMM





###################################
### Existing Non-standard Types ###
Expand Down
20 changes: 20 additions & 0 deletions ontology/yaml/resources/fields/telemetry_fields.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3110,3 +3110,23 @@ literals:
- ultraviolet_irradiance_sensor:
fixed_min: 0.0
flexible_max: 2000.0

- winter_outside_temperature_setpoint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can we have an outside air temperature setpoint? Not following this one.

flexible_min: 255.9259259
flexible_max: 322.037037

- summer_outside_temperature_setpoint:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

flexible_min: 255.9259259
flexible_max: 322.037037

- supply_air_differential_pressure_sensor:
flexible_min: -996.320096
flexible_max: 996.320096

- supply_air_deadband_temperature_setpoint:
flexible_min: 255.9259259
flexible_max: 308.1481481

- season_mode:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would change this to season_command as it has only two states, or season_status if this is a feedback point.

- SUMMER
- WINTER
2 changes: 2 additions & 0 deletions ontology/yaml/resources/states/states.yaml
View file
Open in desktop
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add more details to the descriptions so that they are different from each other and more specific. A device can control based on outdoor temperature and not use this summer/winter control schema. Make it clear that the device has different setpoints based on season.

Original file line number Diff line number Diff line change
Expand Up @@ -90,3 +90,5 @@ SOFTSTART: "Mode of operation of rectifier where the input power supply is gradu
NORMAL: "Function, state or flow which is an ideal or expected condition."
REVERSED: "Function, state or flow which is opposed to the expected or normal condition."

SUMMER: "For devices with control based on outdoor temperature"
WINTER: "For devices with control based on outdoor temperature"