New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile + docker-compose.yaml build/running #93
Dockerfile + docker-compose.yaml build/running #93
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
Add Dockerfile for building with the latest and the docker-compose, building the site and running. $ docker-compose up Starting docsy-example_site_1 ... done Attaching to docsy-example_site_1 site_1 | Start building sites … site_1 | site_1 | | FA | NO | EN site_1 | -------------------+----+----+----- site_1 | Pages | 18 | 76 | 46 site_1 | Paginator pages | 0 | 0 | 0 site_1 | Non-page files | 3 | 1 | 3 site_1 | Static files | 38 | 38 | 38 site_1 | Processed images | 8 | 2 | 7 site_1 | Aliases | 3 | 0 | 3 site_1 | Sitemaps | 2 | 1 | 1 site_1 | Cleaned | 0 | 0 | 0 site_1 | site_1 | Built in 837 ms site_1 | Watching for changes in /src/{assets,content,layouts,package.json,themes} site_1 | Watching for config changes in /src/config.toml, /src/themes/docsy/config.toml site_1 | Environment: "DEV" site_1 | Serving pages from memory site_1 | Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender site_1 | Web Server is available at //localhost:1313/ (bind address 0.0.0.0) site_1 | Press Ctrl+C to stop Open a new terminal and test it $ curl -X HEAD -i localhost:1313 Warning: Setting custom HTTP method to HEAD with -X/--request may not work the Warning: way you want. Consider using -I/--head instead. HTTP/1.1 200 OK Accept-Ranges: bytes Content-Length: 27590 Content-Type: text/html; charset=utf-8 Last-Modified: Thu, 17 Dec 2020 08:47:13 GMT Date: Thu, 17 Dec 2020 08:47:25 GMT
bd80f02
to
c65ffec
Compare
@geriom do you want to take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay Marcello. Thank you for this, I tested it and it works perfectly.
Just a couple of suggestions:
- Change the image name in the compose file.
- Please update the README file with instructions to start and stop the container.
Running with docker-compose is simpler for this case
@geriom I just pushed the changes requested!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Add Dockerfile for building with the latest and the docker-compose, building the site and running. The current version of the
Dockerfile
does not work! It fails... the container stops because of an error...Instead of using the
Dockerfile
, we introduced a new Dockerfile with a different docker image with the latest version.Test logs for current version of Dockerfile -
broken
hugo
...Build and start from
docker-compose
docker-compose
simplifies the development process...docker-compose up -d
to detach the process from the terminal.Open a new terminal and test it