Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart to run docsy-example locally using a Docker container #387

Merged
merged 7 commits into from
Mar 1, 2021

Conversation

geriom
Copy link
Collaborator

@geriom geriom commented Dec 8, 2020

Added a quickstart to get new users up and running in just a few minutes. This PR is contingent on google/docsy-example#75 being merged.


1. [Install git](https://github.com/git-guides/install-git).

## Clone the docsy-example repository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that we now have a template repository, should we tell them to use it as a template and then clone it? If they just clone our repo they still need to create something in GitHub to push their updates to (and change the origin remote, otherwise they'll end up trying to push to docsy-example). Or we can just link to the "don't forget to create a repo to push to" bit from the regular docs afterwards.... What do you think?

git clone --recurse-submodules --depth 1 https://github.com/google/docsy-example.git
```

1. Change your working directory to the newly crated folder:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crated -> created

@@ -0,0 +1,89 @@

---
title: "Quickstart"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think as it is, this is slightly confusing - we have "Quickstart" and "Getting started" as sort of peer pages and it's not clear which one you should go to first (I also have a personal dislike of the term Quickstart but I can live with it. :) ). We also should make it clear that you can use the Docker image as a real environment for working locally on your own sites, not just as a "kick the tyres with the example site" tool for a tutorial.

How about we move this under /getting_started/ and rename it "Quickstart with Docker" (so it'll show up as a sub-page in the nav)

I would also in the main Getting started add a new section under Prerequisites and installation (right at the top so users who don't want to have to install anything can see it) - something like

Use our Docker image

We provide a Docker image that you can use to run and test your Docsy site locally, without having to install all Docsy's dependencies.

You can see how to get started with this approach by following our Quickstart tutorial (linky). If you don't want to use Docker, follow the instructions below to install Hugo and PostCSS.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestions. I just reviewed the docker-compose PR and suggested a couple of changes, as soon as we get that merged I will update this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to get this in now that the Docker update is merged! subtle hint face

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently working on it :)

@geriom
Copy link
Collaborator Author

geriom commented Feb 9, 2021

Updated installation instructions with the requested changes.

@LisaFC
Copy link
Collaborator

LisaFC commented Mar 1, 2021

This is great! I fixed a few nits directly, so it's good to go!

@LisaFC LisaFC merged commit 4b128fc into master Mar 1, 2021
@geriom geriom deleted the geriom-quickstart branch March 31, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants