-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Card- & tab-group styling is no longer included #694
Comments
FYI: I faced this issue with tabbed panes (they were missing the The issue actually stands out on Docsy's docs itself quite nicely here: My workaround currently is to include the css file in the
I could file a PR, but since there seems to be a discussion if it was removed on purpose or not I wasn't sure about it. |
Thanks for the feedback @alexrashed. |
@LisaFC et al.: it seems that #540 may have reverted more changes than I originally pointed out in #652.
For example, it seems that card styles were removed -- see https://github.com/google/docsy/pull/540/files#diff-96dd75a968976edd5e03170268ed9085733f75c3fb24f992ae613c89e6de42dcL41:
As a consequence, the card and tabbed-pane styles aren't being included anymore. To see the difference, compare the following two previews:
You'll notice that in the 540 preview, the cards have lost their custom styling -- such as max-width.
/cc @jcabak @nate-double-u @celestehorgan
The text was updated successfully, but these errors were encountered: