Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card- & tab-group styling is no longer included #694

Open
chalin opened this issue Sep 18, 2021 · 2 comments
Open

Card- & tab-group styling is no longer included #694

chalin opened this issue Sep 18, 2021 · 2 comments

Comments

@chalin
Copy link
Collaborator

chalin commented Sep 18, 2021

@LisaFC et al.: it seems that #540 may have reverted more changes than I originally pointed out in #652.

For example, it seems that card styles were removed -- see https://github.com/google/docsy/pull/540/files#diff-96dd75a968976edd5e03170268ed9085733f75c3fb24f992ae613c89e6de42dcL41:

  {{ end }}
- <!-- stylesheet for tabbed pane -->
- <link rel="stylesheet" href="{{ "/css/shortcodes.css" | relURL }}"/>
  {{ partial "hooks/head-end.html" . }}

As a consequence, the card and tabbed-pane styles aren't being included anymore. To see the difference, compare the following two previews:

You'll notice that in the 540 preview, the cards have lost their custom styling -- such as max-width.

/cc @jcabak @nate-double-u @celestehorgan

@alexrashed
Copy link

alexrashed commented Oct 6, 2021

FYI: I faced this issue with tabbed panes (they were missing the max-width, which then looks a bit weird in combination with other code sections).

The issue actually stands out on Docsy's docs itself quite nicely here:
image

My workaround currently is to include the css file in the _variables_project.scss as follows:

// workaround for https://github.com/google/docsy/issues/694
@import "/css/shortcodes.css";

I could file a PR, but since there seems to be a discussion if it was removed on purpose or not I wasn't sure about it.

alexrashed added a commit to localstack/docs that referenced this issue Oct 6, 2021
thrau pushed a commit to localstack/docs that referenced this issue Oct 6, 2021
@chalin
Copy link
Collaborator Author

chalin commented Oct 6, 2021

Thanks for the feedback @alexrashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants