Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Bootstrap and FontAwesome via NPM packages #904

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Add support for Bootstrap and FontAwesome via NPM packages #904

merged 3 commits into from
Feb 22, 2022

Conversation

chalin
Copy link
Collaborator

@chalin chalin commented Feb 22, 2022

@chalin
Add support for Bootstrap and FontAwesome via NPM packages
df588b2 
- Add FA npm package @5.15.4
- Add bootstrap@4.6.1
- Edit NPM scripts: drop submodule scripts
@chalin
Ensure that UG isn't built using the BS and FA submodules
8939f69
@chalin chalin added the CI/infra CI & infrastructure label Feb 22, 2022
@chalin chalin force-pushed the chalin-bs-and-fa-via-npm-non-brk-2022-02-21 branch from dd646bd to 7b4c15e Compare February 22, 2022 13:06
@chalin
Copy link
Collaborator Author

chalin commented Feb 22, 2022

I've tested this on one of our projects, and I'm able to use this PR w/o it being a breaking change.

Projects can continue to use docsy via a git module with or without recursive submodule dependencies.

To use docsy dependencies via NPM packages one needs to:

  1. Clean out themes/docs by running, e.g., rm -Rf themes/docsy.
  2. Fetch the docsy theme as a submodule again but without the --recursive flag.
  3. Fetch docsy's NPM dependencies by running cd themes/docsy && npm install.

From this point on, build the project as you did before.

@chalin
Copy link
Collaborator Author

chalin commented Feb 22, 2022

Since this isn't a breaking change, and since #889 (of which this PR is a subset) was approved, I'm going to merge this PR.

@chalin chalin merged commit f03cba0 into google:master Feb 22, 2022
@chalin chalin deleted the chalin-bs-and-fa-via-npm-non-brk-2022-02-21 branch February 22, 2022 14:22
@chalin
Copy link
Collaborator Author

chalin commented Feb 22, 2022

The production build is now using BS + FA via NPM packages:

image

For details, see the log: https://app.netlify.com/sites/docsydocs/deploys/6214f1b914a72c0007d91062#L105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/infra CI & infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use NPM packages for Bootstrap and Font Awesome
1 participant
@chalin