Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In ApiDiffChecker, also recognize APIs that have a given annotation.
RELNOTES: none ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=198956503
- Loading branch information
Showing
7 changed files
with
860 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
150 changes: 150 additions & 0 deletions
150
core/src/test/java/com/google/errorprone/bugpatterns/apidiff/AndroidJdkLibsCheckerTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,150 @@ | ||
| /* | ||
| * Copyright 2018 The Error Prone Authors. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.google.errorprone.bugpatterns.apidiff; | ||
|
|
||
|
|
||
| import com.google.errorprone.CompilationTestHelper; | ||
| import java.util.Collections; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; | ||
|
|
||
| /** {@link AndroidJdkLibsChecker}Test. */ | ||
|
|
||
| @RunWith(JUnit4.class) | ||
| public class AndroidJdkLibsCheckerTest extends Java7ApiCheckerTest { | ||
|
|
||
| private final CompilationTestHelper allowJava8Helper = | ||
| CompilationTestHelper.newInstance(AndroidJdkLibsChecker.class, getClass()) | ||
| .setArgs(Collections.singletonList("-XepOpt:Android:Java8Libs")); | ||
|
|
||
| public AndroidJdkLibsCheckerTest() { | ||
| super(AndroidJdkLibsChecker.class); | ||
| } | ||
|
|
||
| @Test | ||
| public void repeatedAnnotationAllowed() { | ||
| compilationHelper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.lang.annotation.Repeatable;", | ||
| "@Repeatable(Test.Container.class)", | ||
| "public @interface Test {", | ||
| " public @interface Container {", | ||
| " Test[] value();", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void typeAnnotationAllowed() { | ||
| compilationHelper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.lang.annotation.Target;", | ||
| "import java.lang.annotation.ElementType;", | ||
| "@Target({ElementType.TYPE_PARAMETER, ElementType.TYPE_USE})", | ||
| "public @interface Test {", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void defaultMethod() { | ||
| compilationHelper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.util.Map;", | ||
| "public class Test {", | ||
| " abstract static class A implements Map<Object, Object> {}", | ||
| " abstract static class B implements Map<Object, Object> {", | ||
| " @Override", | ||
| " public Object getOrDefault(Object key, Object defaultValue) {", | ||
| " return null;", | ||
| " }", | ||
| " }", | ||
| " void f(A a, B b) {", | ||
| " // BUG: Diagnostic contains: java.util.Map#getOrDefault(java.lang.Object,V)" | ||
| + " is not available in Test.A", | ||
| " a.getOrDefault(null, null);", | ||
| " b.getOrDefault(null, null); // OK: overrides getOrDefault", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void typeKind() { | ||
| compilationHelper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "public class Test {", | ||
| " // BUG: Diagnostic contains:", | ||
| " javax.lang.model.type.TypeKind tk;", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void allowJava8Flag_packageWhitelist() { | ||
| allowJava8Helper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.time.Duration;", | ||
| "import java.util.stream.Stream;", | ||
| "import com.google.common.base.Predicates;", | ||
| "import java.util.Arrays;", | ||
| "public class Test {", | ||
| " Duration d = Duration.ofSeconds(10);", | ||
| " public static void test(Stream s) {", | ||
| " s.forEach(i -> {});", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void allowJava8Flag_memberWhitelist() { | ||
| allowJava8Helper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.util.Arrays;", | ||
| "public class Test {", | ||
| " public static void main(String... args) {", | ||
| " Arrays.stream(args);", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| @Test | ||
| public void allowJava8Flag_memberBlacklist() { | ||
| allowJava8Helper | ||
| .addSourceLines( | ||
| "Test.java", | ||
| "import java.util.stream.Stream;", | ||
| "public class Test {", | ||
| " public static void test(Stream s) {", | ||
| " // BUG: Diagnostic contains: parallel", | ||
| " s.parallel();", | ||
| " }", | ||
| "}") | ||
| .doTest(); | ||
| } | ||
|
|
||
| } |
Oops, something went wrong.