Consolidate NamedParameters and ParameterName

Some of this was split out into http://errorprone.info/bugpattern/ParameterComment.html at this point NamedParameters and ParameterName are the same check. RELNOTES: Consolidate NamedParameters and ParameterName ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=181392754
google · Jan 10, 2018 · c215baa · c215baa
1 parent 9a832c3
commit c215baa
Show file tree

Hide file tree

Showing 5 changed files with 360 additions and 633 deletions.
diff --git a/core/src/main/java/com/google/errorprone/bugpatterns/ParameterName.java b/core/src/main/java/com/google/errorprone/bugpatterns/ParameterName.java
@@ -140,7 +140,7 @@ private void checkArgument(
           buildDescription(actual)
               .setMessage(
                   String.format(
-                      "%s does not match parameter name '%s'",
+                      "`%s` does not match formal parameter name `%s`",
                       match.getText(), formal.getSimpleName()))
               .addFix(
                   SuggestedFix.replace(

diff --git a/...ava/com/google/errorprone/bugpatterns/argumentselectiondefects/NamedParameterChecker.java b/...ava/com/google/errorprone/bugpatterns/argumentselectiondefects/NamedParameterChecker.java
diff --git a/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java b/core/src/main/java/com/google/errorprone/scanner/BuiltInCheckerSuppliers.java
@@ -242,7 +242,6 @@
 import com.google.errorprone.bugpatterns.argumentselectiondefects.ArgumentSelectionDefectChecker;
 import com.google.errorprone.bugpatterns.argumentselectiondefects.AssertEqualsArgumentOrderChecker;
 import com.google.errorprone.bugpatterns.argumentselectiondefects.AutoValueConstructorOrderChecker;
-import com.google.errorprone.bugpatterns.argumentselectiondefects.NamedParameterChecker;
 import com.google.errorprone.bugpatterns.collectionincompatibletype.CollectionIncompatibleType;
 import com.google.errorprone.bugpatterns.collectionincompatibletype.CompatibleWithMisuse;
 import com.google.errorprone.bugpatterns.collectionincompatibletype.IncompatibleArgumentType;
@@ -494,7 +493,6 @@ public static ScannerSupplier errorChecks() {
           ModifyCollectionInEnhancedForLoop.class,
           MultipleParallelOrSequentialCalls.class,
           MutableConstantField.class,
-          NamedParameterChecker.class,
           NarrowingCompoundAssignment.class,
           NestedInstanceOfConditions.class,
           NonAtomicVolatileUpdate.class,