Skip to content

Commit

Permalink
Unshade dependencies in error_prone_core
Browse files Browse the repository at this point in the history
error_prone_core had some dependencies shaded that caused problems
with build-system integrations. Moreover, they were still referenced
them in its POM, leading to unnecessary duplications in the classpath.

This commit changes the default error_prone_core artifact to no
longer use shaded dependencies, and moves the shaded artifact to
an additional JAR with 'with-dependencies' classifier. This JAR
is needed to keep the error_prone_refaster JAR identical.

Fixes #501
Updates #482
  • Loading branch information
tbroyer authored and cushon committed Jan 10, 2017
1 parent 275d07a commit cb7eb61
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions core/pom.xml
Expand Up @@ -283,6 +283,8 @@
<goal>shade</goal>
</goals>
<configuration>
<shadedArtifactAttached>true</shadedArtifactAttached>
<shadedClassifierName>with-dependencies</shadedClassifierName>
<createDependencyReducedPom>false</createDependencyReducedPom>
<artifactSet>
<!-- Include only dependencies with compatible licenses.
Expand Down
3 changes: 2 additions & 1 deletion refaster/pom.xml
Expand Up @@ -33,6 +33,7 @@
<groupId>com.google.errorprone</groupId>
<artifactId>error_prone_core</artifactId>
<version>${project.version}</version>
<classifier>with-dependencies</classifier>
<scope>compile</scope>
</dependency>
<dependency>
Expand Down Expand Up @@ -60,7 +61,7 @@
<!-- Include only dependencies with compatible licenses.
Apache, BSD, and MIT are OK; others are not. -->
<includes>
<include>com.google.errorprone:error_prone_core</include>
<include>com.google.errorprone:error_prone_core:with-dependencies</include>
</includes>
</artifactSet>
<transformers>
Expand Down

0 comments on commit cb7eb61

Please sign in to comment.