Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error prone artifact provides guava library #501

Closed
davido opened this issue Jan 5, 2017 · 1 comment
Closed

error prone artifact provides guava library #501

davido opened this issue Jan 5, 2017 · 1 comment

Comments

@davido
Copy link
Contributor

davido commented Jan 5, 2017 •
edited

Is this expected? Bazel and Buck tool chains include their own versions of guava on their classpath (Bazel 21.0-rc1 and Buck 19.0) and after consuming the error prone there is yet another guava version (20 in error prone 2.0.15), so that for example buck autodeps command is failing after adding error prone as native compiler option in Buck, with: [1].

WARNING: Multiple providers for com.google.common.base.Preconditions: //third-party/java/errorprone:error_prone, //third-party/java/guava:guava. Consider adding entry to .buckconfig to eliminate ambiguity:
[autodeps]
java-package-mappings = com.google.common.base.Preconditions => //third-party/java/errorprone:error_prone

[1] http://paste.openstack.org/show/593952
@davido davido mentioned this issue Jan 5, 2017
Closed
@tbroyer
Copy link
Contributor

tbroyer commented Jan 5, 2017

Related: #482 (comment)

tbroyer added a commit to tbroyer/error-prone that referenced this issue Jan 6, 2017
@tbroyer
Unshade dependencies in error_prone_core
acd3f2e 
error_prone_core had some dependencies shaded that caused problems
with build-system integrations. Moreover, they were still referenced
them in its POM, leading to unnecessary duplications in the classpath.

This commit changes the default error_prone_core artifact to no
longer use shaded dependencies, and moves the shaded artifact to
an additional JAR with 'with-dependencies' classifier. This JAR
is needed to keep the error_prone_refaster JAR identical.

Fixes google#501
Updates google#482
@tbroyer tbroyer mentioned this issue Jan 6, 2017
Merged
@kageiit kageiit mentioned this issue Jan 6, 2017
Closed
cushon pushed a commit that referenced this issue Jan 10, 2017
@tbroyer @cushon
Unshade dependencies in error_prone_core
cb7eb61 
error_prone_core had some dependencies shaded that caused problems
with build-system integrations. Moreover, they were still referenced
them in its POM, leading to unnecessary duplications in the classpath.

This commit changes the default error_prone_core artifact to no
longer use shaded dependencies, and moves the shaded artifact to
an additional JAR with 'with-dependencies' classifier. This JAR
is needed to keep the error_prone_refaster JAR identical.

Fixes #501
Updates #482
@big-guy big-guy mentioned this issue Dec 16, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbroyer @davido