Don't fire PreferJavaTimeOverload on custom AssertJ assertThat() overloads. #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterkozak
force-pushed
the
ckozak/assertj_extensions
branch
from
66fcaa3
to
bcafc9a
Compare
|
it's unfortunate there is no dependency on assertj, writing a test is difficult. |
…loads. Fixes google#1435 Related to google#1377 and f1df86d
carterkozak
force-pushed
the
ckozak/assertj_extensions
branch
from
bcafc9a
to
1615c86
Compare
|
|
cgdecker
pushed a commit
that referenced
this pull request
Dec 9, 2019
See #1436 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284565007
Merged
cgdecker
pushed a commit
that referenced
this pull request
Dec 9, 2019
See #1436 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284565007
kmclarnon
pushed a commit
to HubSpot/error-prone
that referenced
this pull request
Feb 19, 2020
See google#1436 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=284565007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1435
Related to #1377 and f1df86d