Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: refactor bad smell UnusedLabel #3519

Closed
wants to merge 2 commits into from
Closed

refactor: refactor bad smell UnusedLabel #3519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90c6fc6
Refactor bad smells:
MartinWitt Nov 3, 2022
c4fdf9c
Update ClassNewInstance.java
MartinWitt Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/java/com/google/errorprone/bugpatterns/ClassNewInstance.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState
// update or add a catch block to handle the new exceptions
private static boolean fixExceptions(VisitorState state, SuggestedFix.Builder fix) {
TryTree tryTree = null;
OUTER:
for (TreePath path = state.getPath(); path != null; path = path.getParentPath()) {
if (path.getLeaf() instanceof CatchTree) {
// don't add more catch blocks if newInstance() was called in a catch block
Expand Down