Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

fix jwks setting thru #1300

Merged
merged 2 commits into from
Jan 20, 2021
Merged

fix jwks setting thru #1300

merged 2 commits into from
Jan 20, 2021

Conversation

mikehelmick
Copy link
Contributor

Fixes #1299

Proposed Changes

  • Fix pointer issue, HealthAuthorityKey.Revoke wasn't updating the struct
  • Move jwks from pkg to internal
  • Add health authority key purge
  • increase test coverage

Release Note

Thru date on health authority keys will be set correctly when they are synced from JWKS sources.

@google-oss-robot google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/L Auto: large number of changes. labels Jan 20, 2021
@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Jan 20, 2021
sethvargo
sethvargo approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@sethvargo sethvargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

internal/verification/database/health_authority_db.go
result, err := tx.Exec(ctx, `
DELETE FROM HealthAuthorityKey
WHERE
health_authority_id = $1 AND (thru_timestamp IS NOT NULL and thru_timestamp < $2)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
health_authority_id = $1 AND (thru_timestamp IS NOT NULL and thru_timestamp < $2)
health_authority_id = $1 AND (thru_timestamp IS NOT NULL AND thru_timestamp < $2)

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Jan 20, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikehelmick, sethvargo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mikehelmick,sethvargo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 6f1aea0 into google:main Jan 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sethvargo sethvargo sethvargo approved these changes

@mariliamelo mariliamelo Awaiting requested review from mariliamelo

Assignees

@sethvargo sethvargo

Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/L Auto: large number of changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JWKS updater - not revoking keys correctly
3 participants
@mikehelmick @google-oss-robot @sethvargo