Skip to content
This repository has been archived by the owner on Jul 12, 2023. It is now read-only.

Use custom http client and customizable timeout for jwks #1342

Merged
merged 1 commit into from Feb 4, 2021
Merged

Use custom http client and customizable timeout for jwks #1342

merged 1 commit into from Feb 4, 2021

Conversation

sethvargo
Copy link
Member

Release Note

Use a custom http client with a separate request timeout for the jwks service. Operators can customize the timeout by setting `REQUEST_TIMEOUT` on the jwks service. The default value is 5 seconds.

/assign @whaught

@google-cla google-cla bot added the cla: yes Auto: added by CLA bot when all committers have signed a CLA. label Feb 4, 2021
@google-oss-robot google-oss-robot added approved Auto: added by prow when enough reviewers approve. size/S Auto: small number of changes. labels Feb 4, 2021
@sethvargo
Copy link
Member Author

This will need a rebase after 1341

whaught
whaught approved these changes Feb 4, 2021
View reviewed changes
Copy link
Contributor

@whaught whaught left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg. needs rebase

@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Feb 4, 2021
@google-oss-robot google-oss-robot removed the lgtm Auto: added by prown with a reviewer LGTMs label Feb 4, 2021
@google-oss-robot google-oss-robot added the lgtm Auto: added by prown with a reviewer LGTMs label Feb 4, 2021
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sethvargo, whaught

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f22fda6 into main Feb 4, 2021
@google-oss-robot google-oss-robot deleted the sethvargo/timeout branch February 4, 2021 16:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@whaught whaught whaught approved these changes

@mikehelmick mikehelmick Awaiting requested review from mikehelmick

@yegle yegle Awaiting requested review from yegle

Assignees

@whaught whaught

Labels
approved Auto: added by prow when enough reviewers approve. cla: yes Auto: added by CLA bot when all committers have signed a CLA. lgtm Auto: added by prown with a reviewer LGTMs size/S Auto: small number of changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sethvargo @google-oss-robot @whaught