Fix for logback version upgrade #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bashir2
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
Thanks for fixing this @chandrashekar-s; please feel free to merge this after addressing the minor comments below.
This was referenced Feb 28, 2024
|
@bashir2 Thanks for the review, I had a bit deeper look at this and have provided my comments. Please check the latest commit as well. |
|
The build is failing due to some regression introduced by the latest HAPI release. This is fixed by the PR #970. We can rebuild this once the fix is merged. |
bashir2
approved these changes
Feb 29, 2024
chandrashekar-s
force-pushed
the
logback-version-fix
branch
2 times, most recently
from
aa06880
to
10c10a0
Compare
bashir2
reviewed
Mar 4, 2024
chandrashekar-s
force-pushed
the
logback-version-fix
branch
from
084a920
to
3ebfa95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what I changed
This fixes the build failure issues for the PRs #957 and #895
E2E test
Relied on e2e test cases
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean packageright before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master