-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for logback version upgrade #969
Fix for logback version upgrade #969
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @chandrashekar-s; please feel free to merge this after addressing the minor comments below.
@bashir2 Thanks for the review, I had a bit deeper look at this and have provided my comments. Please check the latest commit as well. |
The build is failing due to some regression introduced by the latest HAPI release. This is fixed by the PR #970. We can rebuild this once the fix is merged. |
aa06880
to
10c10a0
Compare
084a920
to
3ebfa95
Compare
Description of what I changed
This fixes the build failure issues for the PRs #957 and #895
E2E test
Relied on e2e test cases
TESTED:
Please replace this with a description of how you tested your PR beyond the
automated e2e/unit tests.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master