Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade hapi Fhir version to 7.2.1 #971

Merged
merged 8 commits into from
Jun 26, 2024

Conversation

chandrashekar-s
Copy link
Collaborator

@chandrashekar-s chandrashekar-s commented Feb 28, 2024

Description of what I changed

  • Upgraded HAPI FHIR Version to 7.0.0
  • Made the property name hapi.fhir.version to be same in both bunsen/pom.xml and pipelines/pom.xml files, so that dependabot upgrades the version in both the files simultaneously.
  • Added a dependency hapi-fhir-caching-caffeine, this was mandatory otherwise there was this below error being thrown
java.lang.RuntimeException: HAPI-2200: No Cache Service Providers found. Choose between hapi-fhir-caching-caffeine (Default) and hapi-fhir-caching-guava (Android)

	at ca.uhn.fhir.sl.cache.CacheFactory.getCacheProvider(CacheFactory.java:41)
	at ca.uhn.fhir.sl.cache.CacheFactory.build(CacheFactory.java:46)
	at org.hl7.fhir.r4.hapi.ctx.HapiWorkerContext.<init>(HapiWorkerContext.java:65)
	at org.hl7.fhir.r4.hapi.fluentpath.FhirPathR4.<init>(FhirPathR4.java:31)
	at com.google.fhir.analytics.view.ViewApplicator.<init>(ViewApplicator.java:66)
	at com.google.fhir.analytics.view.ViewApplicatorTest.applyViewOnResource(ViewApplicatorTest.java:72)
	at com.google.fhir.analytics.view.ViewApplicatorTest.emptyForEachOrNullWithUnion(ViewApplicatorTest.java:103)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

E2E test

Relied on E2E tests

TESTED:

Locally tested the full run.

Checklist: I completed these to help reviewers :)

  • I have read and will follow the review process.

  • I am familiar with Google Style Guides for the language I have coded in.

    No? Please take some time and review Java and Python style guides.

  • My IDE is configured to follow the Google code styles.

    No? Unsure? -> configure your IDE.

  • I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)

  • I ran mvn clean package right before creating this pull request and added all formatting changes to my commit.

  • All new and existing tests passed.

  • My pull request is based on the latest changes of the master branch.

    No? Unsure? -> execute command git pull --rebase upstream master

@chandrashekar-s chandrashekar-s requested review from bashir2 and removed request for bashir2 February 28, 2024 15:32
@chandrashekar-s chandrashekar-s marked this pull request as draft February 28, 2024 15:49
@chandrashekar-s
Copy link
Collaborator Author

e2e tests are failing, will debug more on this.

@chandrashekar-s chandrashekar-s changed the title Upgrade hapi Fhir version to 7.0.0 <Draft> Upgrade hapi Fhir version to 7.0.0 Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.92%. Comparing base (810687d) to head (627e21a).

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #971      +/-   ##
============================================
+ Coverage     51.83%   51.92%   +0.09%     
- Complexity      696      697       +1     
============================================
  Files            91       91              
  Lines          5519     5519              
  Branches        709      709              
============================================
+ Hits           2861     2866       +5     
+ Misses         2395     2390       -5     
  Partials        263      263              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chandrashekar-s chandrashekar-s marked this pull request as ready for review June 24, 2024 10:12
@chandrashekar-s chandrashekar-s changed the title <Draft> Upgrade hapi Fhir version to 7.0.0 Upgrade hapi Fhir version to 7.0.0 Jun 24, 2024
@chandrashekar-s
Copy link
Collaborator Author

chandrashekar-s commented Jun 24, 2024

Hi @bashir2, this PR is ready for review, it contains changes for upgrading the HAPI library to 7.2.1

@chandrashekar-s chandrashekar-s changed the title Upgrade hapi Fhir version to 7.0.0 Upgrade hapi Fhir version to 7.2.1 Jun 24, 2024
Copy link
Collaborator

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are minor/questions; please feel free to merge after addressing them.

pipelines/common/pom.xml Outdated Show resolved Hide resolved
pipelines/common/pom.xml Show resolved Hide resolved
@chandrashekar-s
Copy link
Collaborator Author

Thanks @bashir2 for the review. I have addressed the review comments, will merge the changes once the build completes.

@chandrashekar-s chandrashekar-s merged commit 1db3398 into google:master Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants