-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade hapi Fhir version to 7.2.1 #971
Conversation
e2e tests are failing, will debug more on this. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
============================================
+ Coverage 51.83% 51.92% +0.09%
- Complexity 696 697 +1
============================================
Files 91 91
Lines 5519 5519
Branches 709 709
============================================
+ Hits 2861 2866 +5
+ Misses 2395 2390 -5
Partials 263 263 ☔ View full report in Codecov by Sentry. |
Hi @bashir2, this PR is ready for review, it contains changes for upgrading the HAPI library to 7.2.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments are minor/questions; please feel free to merge after addressing them.
Thanks @bashir2 for the review. I have addressed the review comments, will merge the changes once the build completes. |
Description of what I changed
hapi.fhir.version
to be same in bothbunsen/pom.xml
andpipelines/pom.xml
files, so that dependabot upgrades the version in both the files simultaneously.hapi-fhir-caching-caffeine
, this was mandatory otherwise there was this below error being thrownE2E test
Relied on E2E tests
TESTED:
Locally tested the full run.
Checklist: I completed these to help reviewers :)
I have read and will follow the review process.
I am familiar with Google Style Guides for the language I have coded in.
No? Please take some time and review Java and Python style guides.
My IDE is configured to follow the Google code styles.
No? Unsure? -> configure your IDE.
I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests)
I ran
mvn clean package
right before creating this pull request and added all formatting changes to my commit.All new and existing tests passed.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master