-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The win32 implementation of getCanonicalPath doesn't work the same as the base implementation #13
Comments
Thanks for reporting these issues- seems like valid bugs. Will take a look. |
This was referenced Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Win32 implementation calls the Windows SDK function PathCanonicalize but it only works correctly when called with a fully qualified path it seems.
Example : the README for Windows says to test the compiled code with
./samples/material_sandbox --ibl=../samples/envs/office ../assets/models/sphere/sphere.obj
This results directly in calling getCanonicalPath with
../samples/envs/office
which then returnssamples/envs/office
and then the IBL isn't found.The same issue applies directly to the path for the obj file to open.
Workaround : pass absolute paths. This doesn't work for the IBL though because of another issue later on with path concatenation.
The text was updated successfully, but these errors were encountered: