Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The win32 implementation of getCanonicalPath doesn't work the same as the base implementation #13

Closed
Stof25 opened this issue Aug 5, 2018 · 1 comment · Fixed by #49
Assignees
Labels
bug Something isn't working windows Issue/feature request for Windows only

Comments

@Stof25
Copy link

Stof25 commented Aug 5, 2018

Win32 implementation calls the Windows SDK function PathCanonicalize but it only works correctly when called with a fully qualified path it seems.

Example : the README for Windows says to test the compiled code with
./samples/material_sandbox --ibl=../samples/envs/office ../assets/models/sphere/sphere.obj

This results directly in calling getCanonicalPath with ../samples/envs/office which then returns samples/envs/office and then the IBL isn't found.

The same issue applies directly to the path for the obj file to open.

Workaround : pass absolute paths. This doesn't work for the IBL though because of another issue later on with path concatenation.

@romainguy romainguy added the bug Something isn't working label Aug 5, 2018
@bejado
Copy link
Member

bejado commented Aug 5, 2018

Thanks for reporting these issues- seems like valid bugs. Will take a look.

@romainguy romainguy added the windows Issue/feature request for Windows only label Aug 8, 2018
@bejado bejado closed this as completed in #49 Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Issue/feature request for Windows only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants