Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some doc typos #7

Merged
merged 3 commits into from
Aug 4, 2018
Merged

Fix some doc typos #7

merged 3 commits into from
Aug 4, 2018

Conversation

Jjagg
Copy link
Contributor

@Jjagg Jjagg commented Aug 4, 2018

No description provided.

Copy link
Collaborator

@romainguy romainguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@romainguy romainguy merged commit fd38053 into google:master Aug 4, 2018
@geroge-d geroge-d mentioned this pull request Sep 3, 2019
rbsheth pushed a commit to rbsheth/filament that referenced this pull request Jun 30, 2022
Enhance Animator to allow reusable animation (google#8)
- allow an Animator to be created explictly with an animation asset
- such an Animator is "empty" as it contain animation data but is not
hooked up to any entities
- call addAnimatedAsset to apply the animation to a model asset

Enhance morpher: add CPU morpher (google#7)
- add cpu morpher which supports more than 4 active targets
- add common interface for morphers
- change Animator to allow swapping out the stock MorphHelper for the
new CPUMorpher
- change Animator to allow morphers to be managed externally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants