Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more improvements to filaflat #931

Merged
merged 5 commits into from
Mar 6, 2019
Merged

more improvements to filaflat #931

merged 5 commits into from
Mar 6, 2019

Commits on Mar 5, 2019

  1. Merge [Spirv|Text]DictionaryReadder into DictionaryReader

    @pixelflinger
    pixelflinger committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    d69898e View commit details
    Browse the repository at this point in the history

  2. Factorize all the various getShader() methods 

    This removes a lot of code and complexity. MaterialParser now has 
a single, generic getShader() method.
    @pixelflinger
    pixelflinger committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    0962cd4 View commit details
    Browse the repository at this point in the history

  3. MaterialChunk doesn't expose the Unflattener in its API 

    this makes the API more robust, because now it's not possible
to mess up the call to getShader(), by construction.
    @pixelflinger
    pixelflinger committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    b471ec1 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. cleanup MaterialChunkType.h

    @pixelflinger
    pixelflinger committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    1a41f13 View commit details
    Browse the repository at this point in the history

  2. cleanup filamat namespace

    @pixelflinger
    pixelflinger committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    2f101a8 View commit details
    Browse the repository at this point in the history