more improvements to filaflat #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a lot of code and complexity. MaterialParser now has a single, generic getShader() method.
this makes the API more robust, because now it's not possible to mess up the call to getShader(), by construction.
pixelflinger
force-pushed
the
ma/dictionary
branch
from
e5a3ea6
to
b471ec1
Compare
prideout
approved these changes
Mar 6, 2019
| @@ -37,7 +37,7 @@ class BlobDictionary { | |||
| } | |||
|
|
|||
| inline void addBlob(Blob&& blob) noexcept { | |||
| mBlobs.emplace_back(std::move(blob)); | |||
| mBlobs.push_back(std::move(blob)); | |||
There was a problem hiding this comment.
Remind me why this preferable here?
There was a problem hiding this comment.
I don't think it's preferable, it's just that emplace_back() is for passing the parameters that the ctor would take. Here we're just emplacing_back with the copy-ctor, which doesn't do anything different than push_back.
romainguy
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.