Turn on gRPC tests in travis build #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Download and build with a known grpc version
|
This is great! Worried that it will slow down our CI yet more, but hey, this is important to test. Thanks for making it work! |
shivendra14
pushed a commit
to shivendra14/flatbuffers
that referenced
this pull request
Nov 13, 2018
Download and build with a known grpc version
zchee
pushed a commit
to zchee/flatbuffers
that referenced
this pull request
Feb 14, 2019
Download and build with a known grpc version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
.travis.ymlfile to run the gRPC tests during the regular CI step. Only Linux and Mac platforms are supported at the moment. The travis file invokesgrpc/build_grpc.shthat clones grpc repo, checkout a specfic githash (v 1.15.1 at the moment), builds it, and uses it to test the grpc tests. The test I would like to run at every flatbuffers CI aregrpc/test_message_builder.cpp.Due to some quirks on Mac,
make test ARGS=-Vdoes not work. So it calls the tests explicitly.