[TS] Escape keywords in typescript object names #7137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c#
c++
codegen
This was referenced Mar 1, 2022
jkuszmaul
force-pushed
the
escape_object_names
branch
5 times, most recently
from
31e32a1
to
a351f50
Compare
|
Well I seem to have finally landed on a combination of keywords in |
19 tasks
dbaileychess
reviewed
Mar 3, 2022
jkuszmaul
force-pushed
the
escape_object_names
branch
from
a351f50
to
124b707
Compare
|
Merge conflict now. |
* Add Object to the list of reserved keywords. * Properly escape keywords in type names. * Properly escape keywords in enum names. * Properly escape keywords in enum field names.
jkuszmaul
force-pushed
the
escape_object_names
branch
from
124b707
to
300d542
Compare
dbaileychess
approved these changes
Mar 5, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6994
To just review the actual changes, just look at the first commit in the chain; the second commit is running generate_code.py to update all the generated code.