Typo in flatc options (warning-as-errors instead of warnings-as-errors)

[stefan301]

No description provided.

[CasperN]

Hello, thanks for contributing.

• You have to update opts.warnings_as_errors too, which is where the changed string is consumed

This is also a breaking change for people who use flatc in scripts. Can you:

• Make a new flag with the correct spelling (instead of replacing the old one)
• Add a TODO comment to delete the old flag in the next breaking release.
• Update the old flag's description to say it's deprecated in favor of the new flag
• Warn when the old flag is used

[stefan301]

This was only a typo in flatc -h
The real option is already --warnings-as-error

      } else if (arg == "--warnings-as-errors") {
        opts.warnings_as_errors = true;

[CasperN]

sgtm