[C++] stl_emulation span::count_ is not const anymore (#7226) #7227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In C++ we cannot have both assignment operator and const member. Since span::operator= is defined, span::count_ constness must be removed.
|
Thanks! |
|
Fixes #7226 |
|
Hello, |
ltoenning
added a commit
to ltoenning/BehaviorTree.CPP
that referenced
this pull request
May 20, 2024
Backport/update from upstream flatbuffers repository. Change taken from google/flatbuffers#7227
ltoenning
added a commit
to ltoenning/BehaviorTree.CPP
that referenced
this pull request
May 20, 2024
Backport/update from upstream flatbuffers repository. Change taken from google/flatbuffers#7227
ltoenning
added a commit
to ltoenning/BehaviorTree.CPP
that referenced
this pull request
May 20, 2024
Original author of change: avaliente-bc Backport/update from upstream flatbuffers repository. Change taken from google/flatbuffers#7227
facontidavide
pushed a commit
to BehaviorTree/BehaviorTree.CPP
that referenced
this pull request
May 30, 2024
* From flatbuffers upstream: Fix compiler error Original author of change: avaliente-bc Backport/update from upstream flatbuffers repository. Change taken from google/flatbuffers#7227 * From flatbuffers upstream: Fix include of string_view with C++17 abseil Original author of change: ocpalo Backport/update from upstream flatbuffers repository. Changes taken from google/flatbuffers#7897.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In C++ we cannot have both assignment operator and const member.
Since span::operator= is defined, span::count_ constness must be removed.
This fixes a build issue with C++ IAR compiler