[GO] Verifier #8030
[GO] Verifier #8030
Conversation
Pull from google/flatbuffers
If a struct has a key the vector has to be sorted. To sort the vector you can't use "const".
* option indent_step is supported
Pull from google
Pull from google
Pull from master
github-actions
bot
added
golang
c++
grpc
codegen
go/verify.go
Outdated
| // | ||
| // /* Verify Monster table. Buffer name is 'MONS' and contains data length prefix */ | ||
| // isValid := verifier.VerifyBuffer("MONS", true, MonsterVerify) | ||
| func (verifier *Verifier) VerifyBuffer(identifier []byte, sizePrefixed bool, verifyObjFunc VerifyTableFunc) bool { |
There was a problem hiding this comment.
In other places, I've used the type string for the identifier, see for example the code in go/lib.go and the FooIdentifier constants in the generated code. So I suggest to use string also in this code, for consistency.
Interestingly, your last example line
isValid := verifier.VerifyBuffer("MONS", true, MonsterVerify)
already assumes a string.
docs/source/GoUsage.md
Outdated
| For a more detailed control of verification `MonsterVerify` for `Monster` | ||
| type can be used: | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~{.go} | ||
| # Sequence of calls |
There was a problem hiding this comment.
This looks like a mixture of Go and Python syntax somehow...
- To fix
b'MONS', I suggest simply using strings, so that would become"MONS". - The trailing
\is invalid and can be removed as the line end with a. - Comments start with
//
There was a problem hiding this comment.
To many different languages at the same time. fixed.
docs/source/GoUsage.md
Outdated
| Each root type will have a verification function generated for it, | ||
| e.g. `VerifyMonster`. This can be called as shown: | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~{.go} | ||
| ok := VerifyMonster(buf); |
tests/MyGame/Example/Any.go
Outdated
| switch Any(typeId) { | ||
| case AnyMonster: | ||
| result = MonsterVerify(verifier, tablePos) | ||
| break |
There was a problem hiding this comment.
In Go, these break statements are not needed
tests/MyGame/Example/Referrable.go
Outdated
| @@ -47,6 +47,11 @@ func FinishReferrableBuffer(builder *flatbuffers.Builder, offset flatbuffers.UOf | |||
| builder.Finish(offset) | |||
| } | |||
|
|
|||
| func VerifyReferrable(buf []byte) bool { | |||
| return flatbuffers.NewVerifier(buf).VerifyBuffer(nil, false, ReferrableVerify) | |||
|
|
|||
There was a problem hiding this comment.
Avoid generating an empty line here
|
What about the build step |
|
Any updates? |
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
|
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
|
not-stale |
Here a PR for verifier for GO.
I have added