Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ConvLSTMCell to docs. #3712

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Add ConvLSTMCell to docs. #3712

merged 1 commit into from
Mar 13, 2024

Conversation

carlosgmartin
Copy link
Contributor

@carlosgmartin
Copy link
Contributor Author

@chiamp @cgarciae How does this look?

Copy link
Collaborator

@cgarciae cgarciae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlosgmartin for doing this!

@chiamp
Copy link
Collaborator

chiamp commented Mar 13, 2024

CI is breaking due to an unrelated failure, but we recently pushed a change to fix this. Could you rebase?

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.70%. Comparing base (50b589f) to head (1c9cdc1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3712   +/-   ##
=======================================
  Coverage   58.70%   58.70%           
=======================================
  Files         102      102           
  Lines       12412    12412           
=======================================
  Hits         7286     7286           
  Misses       5126     5126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@carlosgmartin
Copy link
Contributor Author

@chiamp Done.

@copybara-service copybara-service bot merged commit 3da44bc into google:main Mar 13, 2024
19 checks passed
@carlosgmartin carlosgmartin deleted the conv_lstm_cell_docs branch March 13, 2024 19:55
@carlosgmartin
Copy link
Contributor Author

@chiamp Thanks. On a related note, I suggested a small improvement to the contributing doc here: #3757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants