rename ConvLSTM to ConvLSTMCell #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastings
approved these changes
Jan 9, 2023
|
@bastings Marc was looking through the internal code base and it seems the issue is not that hard to solve, just changing a couple names. Wondering if you could help me do this in the CL? 🙏 For OSS users we can bump the Flax version to |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames
ConvLSTMtoConvLSTMCellfor consistency. Since we are going to add full layers likeRNNandCudnnLSTMin the near future, its imporant to be able to properly distinguish between cells and layers.