Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nnx] add pytree support #3732

Merged
merged 1 commit into from
Mar 13, 2024
Merged

[nnx] add pytree support #3732

merged 1 commit into from
Mar 13, 2024

Conversation

cgarciae
Copy link
Collaborator

@cgarciae cgarciae commented Mar 1, 2024

What does this PR do?

Add support for Pytree nodes in graph_utils

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@cgarciae cgarciae force-pushed the add-pytree-support branch 8 times, most recently from f0d0ca7 to 2850c08 Compare March 2, 2024 19:32
@cgarciae cgarciae changed the base branch from main to nnx-cleanup-graph-utils March 2, 2024 19:35
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 58.70%. Comparing base (0c7d256) to head (c898774).
Report is 3 commits behind head on main.

Files Patch % Lines
flax/experimental/nnx/nnx/graph_utils.py 90.62% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   58.43%   58.70%   +0.27%     
==========================================
  Files         102      102              
  Lines       12365    12412      +47     
==========================================
+ Hits         7225     7286      +61     
+ Misses       5140     5126      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgarciae cgarciae force-pushed the add-pytree-support branch 2 times, most recently from dfd5016 to 9383573 Compare March 2, 2024 23:40
Base automatically changed from nnx-cleanup-graph-utils to main March 8, 2024 02:27
@copybara-service copybara-service bot merged commit 9fbf69d into main Mar 13, 2024
21 checks passed
@copybara-service copybara-service bot deleted the add-pytree-support branch March 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants