FlexboxItemDecoration not correct in FlexboxItemDecoration

[ly85206559]

• I have searched existing issues and confirmed this is not a duplicate

Issues and steps to reproduce

if i do not use decoration,the flexboxlayoutmanager show correct,if i user decoration,the each item of recycle view do not show fully.
Like this:
not use decoration
Text1Text2Text3Text4
Text5Text6Text7Text8
use decoration
Tex... Tex... Tex... Tex...
Tex... Tex... Tex... Tex...

Expected behavior

like this:
Text1 Text2 Text3
Text4 Text5 Text6
Text7 Text8

Version of the flexbox library

e.g. 0.2.6, 0.3.0-alpha3

Link to code

    RecyclerView recyclerView = (RecyclerView) findViewById(R.id.list);
    TagAdapter adapter = new TagAdapter(this, Arrays.asList(tags));
    recyclerView.setAdapter(adapter);

    FlexboxLayoutManager manager = new FlexboxLayoutManager(this, FlexDirection.ROW);
    manager.setFlexWrap(FlexWrap.WRAP);
    recyclerView.setLayoutManager(manager);
    FlexboxItemDecoration decoration = new FlexboxItemDecoration(this);
    decoration.setOrientation(FlexboxItemDecoration.BOTH);
    decoration.setDrawable(getDrawable(R.drawable.divider));
    recyclerView.addItemDecoration(decoration);

I read the source code ,and i think there maybe have problem.
in FlexBoxHelper->isWrapRequired method
int decorationLength =
mFlexContainer.getDecorationLengthMainAxis(view, index, indexInFlexLine);
this line return 0 but i set the decoration.

And i find must invoke calculateItemDecorationsForChild(view,rect) first, otherwise can not get the correct decoration

[thagikura]

Thanks for filing this.

As you say it looks like the decoration length should be calculated before calling the isWrapRequired method

[ly85206559]

Thanks , and i am now working on it.

[thagikura]

That would be great. Thanks for doing that.

[ghost]

Are there any timely plans for this to get merged and making a new release?

[thagikura]

Sorry at this moment, there isn't a fixed plan when this is fixed.
This issue isn't as easy as it looks.

[ghost]

That's sad because right now Item Decorations can't be used with Flexbox Layout Manager

[thagikura]

Let me try to fix it before too long.

[hangnadi]

is it still ? I use v0.3.2

[HelenaSewell]

I'm also encountering this issue. What's odd is that if I set my (TextView) items to be single line, the text gets cut off, but the textview itself appears to be the correct size. Sort of like this: [an-_____].
This only happens on lines just at the point of being long enough to move the item. (This means that the smaller the width of the items, the more likely this is to happen)
Using 0.3.2.