force set all items to adapter when wrap_content is set to RV, issues… #507
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it!) |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
| @@ -312,6 +320,14 @@ public void setFlexWrap(@FlexWrap int flexWrap) { | |||
| } | |||
| } | |||
|
|
|||
| public Boolean getmSetAllItemsForced() { | |||
There was a problem hiding this comment.
Better would be to have it here areAllItemsForced() or something similar.
| return mSetAllItemsForced; | ||
| } | ||
|
|
||
| public void setmSetAllItemsForced(Boolean mSetAllItemsForced) { |
There was a problem hiding this comment.
Same as above, naming needs correction.
| @@ -874,7 +890,8 @@ private void updateFlexLines(int childCount) { | |||
| // passed as 0 from the RecyclerView) | |||
| // Set the upper limit as the height of the device in order to prevent computing all | |||
| // items in the adapter | |||
| needsToFill = mLayoutState.mInfinite ? | |||
| // or set the mSetAllItemsForced to true to force all items to show | |||
| needsToFill = mSetAllItemsForced ? 999999999 : mLayoutState.mInfinite ? | |||
There was a problem hiding this comment.
Maybe instead this 999999999 let's put Integer.MAX_VALUE ?
| @@ -885,7 +902,8 @@ private void updateFlexLines(int childCount) { | |||
| // passed as 0 from the RecyclerView) | |||
| // Set the upper limit as the width of the device in order to prevent computing all | |||
| // items in the adapter | |||
| needsToFill = mLayoutState.mInfinite ? | |||
| // or set the mSetAllItemsForced to true to force all items to show | |||
| needsToFill = mSetAllItemsForced ? 999999999 : mLayoutState.mInfinite ? | |||
There was a problem hiding this comment.
Maybe instead this 999999999 let's put Integer.MAX_VALUE ?
… fixed: #349 #336 #339