Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused Field #102

Closed
QiAnXinCodeSafe opened this issue Sep 3, 2019 · 2 comments · Fixed by #103
Closed

Unused Field #102

QiAnXinCodeSafe opened this issue Sep 3, 2019 · 2 comments · Fixed by #103
Assignees
@kluever
Labels
P4 type=other Miscellaneous activities not covered by other type= labels

Comments

@QiAnXinCodeSafe
Copy link

flogger/api/src/main/java/com/google/common/flogger/backend/Platform.java

Line 40 in 477d892

private static String ANDROID_PLATFORM =

This field is never used.
@kluever
Copy link
Member

kluever commented Sep 3, 2019

It is used internally, but yes, I suppose we could strip that String if we really wanted to.

@kluever kluever self-assigned this Sep 3, 2019
@kluever kluever added P4 type=other Miscellaneous activities not covered by other type= labels labels Sep 3, 2019
@kluever
Copy link
Member

kluever commented Sep 3, 2019

Fixed internally...will be mirrored out shortly.

@kluever kluever closed this as completed Sep 3, 2019
kluever added a commit that referenced this issue Sep 3, 2019
@kluever
Mark ANDROID_PLATFORM as @GoogleInternal.
577e37c 
Fixes #102

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=266957001
@kluever kluever mentioned this issue Sep 3, 2019
Merged
kluever added a commit that referenced this issue Sep 3, 2019
@kluever
Mark ANDROID_PLATFORM as @GoogleInternal.
3f82fdd 
Fixes #102

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=266957001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kluever kluever

Labels
P4 type=other Miscellaneous activities not covered by other type= labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moe Sync google/flogger
2 participants
@kluever @QiAnXinCodeSafe